Conversation
Signed-off-by: Paulo Gomes <paulo@entire.io>
Signed-off-by: Paulo Gomes <paulo@entire.io>
There was a problem hiding this comment.
Pull request overview
This PR updates the project to target Go 1.27 and adopts newer standard-library conveniences enabled by that bump, while tightening a few tests to be less environment-dependent.
Changes:
- Bump the module’s Go version to
go 1.27.0and update tooling (golangci-lint). - Use newer stdlib helpers (
strings.Cut,slices.Contains) and Go 1.25+sync.WaitGroup.Go. - Adjust tests for embedded
HostAccessfields and make runner-binary detection tests deterministic.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| internal/types/workload.go | Minor refactor using strings.Cut and inline initialization of EffectiveWorkload.Name. |
| internal/types/workload_test.go | Updates profile initializers to use promoted fields from embedded HostAccess. |
| internal/runners/util/container/redact_test.go | Removes now-unnecessary loop-variable shadowing under newer Go range semantics. |
| internal/images/images.go | Simplifies goroutine + waitgroup wiring with wg.Go. |
| internal/flatpak/flatpak.go | Replaces manual loop membership check with slices.Contains. |
| internal/files/binaries_test.go | Makes ContainerRunnerBinary test deterministic by controlling PATH. |
| internal/command/command.go | Modernizes variadic parameter type to ...any. |
| hack/base.mk | Bumps golangci-lint version. |
| go.mod | Updates go directive to 1.27.0. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.